Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: enabled effect and drop unecessary refs #213

Merged
merged 1 commit into from
May 31, 2021

Conversation

DorianMaliszewski
Copy link
Member

What I did

  • Fix when enabled change it will run useEffect too handle the request (when disable by default and then enabling isIdle still true so no useEffect)
  • Drop unsued ref to onSuccess and onError

@codecov
Copy link

codecov bot commented May 31, 2021

Codecov Report

Merging #213 (a06b9ca) into master (ad5d479) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #213   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            8         8           
  Lines          275       273    -2     
  Branches        40        40           
=========================================
- Hits           275       273    -2     
Impacted Files Coverage Δ
packages/use-dataloader/src/useDataLoader.js 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad5d479...a06b9ca. Read the comment docs.

@DorianMaliszewski DorianMaliszewski merged commit abe7409 into master May 31, 2021
@DorianMaliszewski DorianMaliszewski deleted the fix/effect-improvments branch May 31, 2021 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants