Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't display "Fill segment" option if editable mapping is active #7975

Merged

Conversation

dieknolle3333
Copy link
Contributor

@dieknolle3333 dieknolle3333 commented Aug 5, 2024

URL of deployed dev instance (used for testing):

How to test

  • create editable mapping and make sure that flood filling is not available in the context menu any more
  • advanced: change code so that it is available in context menu again, and click is while editable mapping is active. there should be a toast and a console.error.
  • in an annotation with a segmentation layer, turn it invisible and turn on a skeleton layer. now only skeleton options should be available in the context menu in the viewport, matching the disabled volume actions in the action bar.

TODOs:

  • disable flood filling if there is no active segmentation layer
  • see if disabledVolumeInfo can be used even more
  • DRY nonSkeletonActions

Issues:


(Please delete unneeded items, merge only when none are left open)

  • Updated changelog
  • Removed dev-only changes like prints and application.conf edits

@dieknolle3333 dieknolle3333 marked this pull request as ready for review August 6, 2024 11:49
Copy link
Member

@philippotto philippotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great :) only see my one comment.

@dieknolle3333 dieknolle3333 enabled auto-merge (squash) August 7, 2024 11:46
@dieknolle3333 dieknolle3333 merged commit 5e29e92 into master Aug 7, 2024
2 checks passed
@dieknolle3333 dieknolle3333 deleted the disable-fill-segment-with-active-editable-mapping branch August 7, 2024 12:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fill Segment can be triggered while an editable mapping is active
2 participants