Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix saving volume after brushing on mapped fallback buckets #7833

Merged
merged 4 commits into from
May 30, 2024
Merged

Fix saving volume after brushing on mapped fallback buckets #7833

merged 4 commits into from
May 30, 2024

Conversation

fm3
Copy link
Member

@fm3 fm3 commented May 27, 2024 •
edited
Loading

URL of deployed dev instance (used for testing):

Steps to test:

  • Create annotation on dataset with agglomerate mappings and with a segment index (e.g. test-agglomerate-file)
  • Activate mapping, brush some with new segment id (popup on mapping locking should appear)
  • Saving should still work
  • Right-click on new segment, segment stats should look plausible
  • Compute some ad-hoc meshes, should also still work

Issues:

@fm3 fm3 self-assigned this May 27, 2024
@fm3 fm3 marked this pull request as ready for review May 27, 2024 09:51
MichaelBuessemeyer
MichaelBuessemeyer approved these changes May 28, 2024
View reviewed changes
Copy link
Contributor

@MichaelBuessemeyer MichaelBuessemeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM: Fix works and bug still exists on master 🎉

@fm3 fm3 enabled auto-merge (squash) May 30, 2024 07:38
@fm3 fm3 merged commit 7df0ce7 into master May 30, 2024
2 checks passed
@fm3 fm3 deleted the fix-brushing-on-fallback-mapping branch May 30, 2024 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaelBuessemeyer MichaelBuessemeyer MichaelBuessemeyer approved these changes

Assignees

@fm3 fm3

Labels
backend bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Volume saving with Fallback Layer with Segment Index File fails
2 participants
@fm3 @MichaelBuessemeyer