Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix cubeSize + padding for non-mag1 ad-hoc meshes #7799

Merged
merged 4 commits into from
May 14, 2024
Merged

Fix cubeSize + padding for non-mag1 ad-hoc meshes #7799

merged 4 commits into from
May 14, 2024

Conversation

fm3
Copy link
Member

@fm3 fm3 commented May 14, 2024 •
edited
Loading

URL of deployed dev instance (used for testing):

Steps to test:

  • Create volume annotation with very coarse mags only. Brush some, load ad-hoc mesh
  • Should load a fully closed complete mesh

Issues:

@fm3 fm3 self-assigned this May 14, 2024
@fm3 fm3 marked this pull request as ready for review May 14, 2024 12:47
@fm3 fm3 requested a review from philippotto May 14, 2024 12:47
philippotto
philippotto approved these changes May 14, 2024
View reviewed changes
Copy link
Member

@philippotto philippotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome, thanks for fixing this 🙏 I suggested two var extractions.

frontend/javascripts/oxalis/model/sagas/mesh_saga.ts Outdated Show resolved Hide resolved
frontend/javascripts/oxalis/model/sagas/mesh_saga.ts Outdated Show resolved Hide resolved
@fm3 fm3 enabled auto-merge (squash) May 14, 2024 13:06
@fm3 fm3 merged commit 3ab7382 into master May 14, 2024
2 checks passed
@fm3 fm3 deleted the adhocmesh-cubesize branch May 14, 2024 13:20
@fm3 fm3 mentioned this pull request May 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@philippotto philippotto philippotto approved these changes

Assignees

@fm3 fm3

Labels
backend bug frontend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Ad hoc meshing does not work for segmentations with mags >= 64
2 participants
@fm3 @philippotto