Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added type definitions for @scalableminds/prop-types #7744

Merged
merged 3 commits into from
Apr 10, 2024

Conversation

hotzenklotz
Copy link
Member

@hotzenklotz hotzenklotz commented Apr 10, 2024

I added the Typescript types definitions for the @scalableminds/prop-types package. Since we forked the package, we can not just install @types/prop-types. Therefore, I copied the type definition (MIT license) and adjusted them to fit out package structure.

Steps to test:

  • Run typechecker

(Please delete unneeded items, merge only when none are left open)

Copy link
Member

@philippotto philippotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

awesome 👍

@hotzenklotz hotzenklotz merged commit fc5163d into master Apr 10, 2024
2 checks passed
@hotzenklotz hotzenklotz deleted the types-for-proptypes branch April 10, 2024 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants