Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix that teamless users were not listed #7721

Merged
merged 4 commits into from
Apr 8, 2024
Merged

Fix that teamless users were not listed #7721

merged 4 commits into from
Apr 8, 2024

Conversation

fm3
Copy link
Member

@fm3 fm3 commented Mar 26, 2024

Fixes regression from #7646 – I hadn’t been aware that users without teams were even allowed… I think this double left join here now should not cause new fanout duplicates since there is only one team per user_team_role

URL of deployed dev instance (used for testing):

Steps to test:

  • Remove all team memberships from a user
  • They should still be listed in api/users

@fm3 fm3 self-assigned this Mar 26, 2024
@fm3 fm3 changed the title List teamless users Fix that teamless users were not listed Mar 26, 2024
@fm3 fm3 marked this pull request as ready for review March 26, 2024 14:07
@fm3 fm3 requested a review from normanrz March 26, 2024 14:07
@fm3
Copy link
Member Author

fm3 commented Apr 8, 2024

@normanrz maybe you could have a look at this? :)

@fm3 fm3 enabled auto-merge (squash) April 8, 2024 13:35
@fm3 fm3 merged commit 7efc10c into master Apr 8, 2024
2 checks passed
@fm3 fm3 deleted the list-teamless-users branch April 8, 2024 14:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants