Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix loki #7684

Merged
merged 5 commits into from
Mar 14, 2024
Merged

Fix loki #7684

merged 5 commits into from
Mar 14, 2024

Conversation

normanrz
Copy link
Member

@normanrz normanrz commented Mar 13, 2024

Loki expects all key-value pairs to have string values. It seems like older versions (2.7) didn't validate that strictly, though. The new versions (2.9) do. This PR sprinkles in a few toString calls.

Steps to test:

  • Enable voxelytics in config, set a loki uri
  • Run a vx workflow against your local webknossos

@normanrz normanrz requested a review from fm3 March 13, 2024 10:33
@normanrz normanrz self-assigned this Mar 13, 2024
Copy link
Member

@fm3 fm3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

I guess we could also just replace the .as[Long] by .as[String] in these spots, but no strong opinion.

@normanrz
Copy link
Member Author

I guess we could also just replace the .as[Long] by .as[String] in these spots, but no strong opinion.

I think that would expect a string in the json, but these are numbers.

@fm3
Copy link
Member

fm3 commented Mar 14, 2024

I think that would expect a string in the json, but these are numbers.

Yeah that may be right. Feel free to merge as is then :)

@normanrz normanrz merged commit 6cdddfb into master Mar 14, 2024
2 checks passed
@normanrz normanrz deleted the fix-loki branch March 14, 2024 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants