Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

small documentation updates for N5 and Neuroglancer Precomputed #7622

Merged
merged 2 commits into from
Feb 14, 2024

Conversation

hotzenklotz
Copy link
Member

@hotzenklotz hotzenklotz commented Feb 13, 2024

As a follow up to PR #7578, I added some more small documentation "hints" for support of N5 and Neuroglancer precomputed datasets when uploading datasets.

Additionally I fixed a antd warning. <Spin tip={"Some text"} /> requires the use of children. See docs https://ant.design/components/spin. Additionally the "spin" text would be stacked vertically, because the <Spin /> did not have enough width / no-width defined at all. By wrapping the whole modal this can be fixed - even though it is not the prettiest solution. Anyway, this spinner should only ever be visible for a short time anyway if at all.

With fix:
image

Warning
Screenshot 2024-02-13 at 14 31 14

URL of deployed dev instance (used for testing):

  • https://___.webknossos.xyz

Steps to test:

Issues:


(Please delete unneeded items, merge only when none are left open)

@hotzenklotz hotzenklotz marked this pull request as ready for review February 13, 2024 14:02
Copy link
Member

@philippotto philippotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@hotzenklotz hotzenklotz merged commit 1d93c37 into master Feb 14, 2024
2 checks passed
@hotzenklotz hotzenklotz deleted the docs-n5-neuroglancer branch February 14, 2024 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants