Fix listing other users’ annotations #7563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hotzenklotz
reviewed
Jan 17, 2024
| @@ -553,15 +553,6 @@ export function deletePrivateLink(linkId: string): Promise<{ | |||
| } | |||
|
|
|||
| // ### Annotations | |||
| export function getAnnotationInfos( | |||
There was a problem hiding this comment.
Am I assuming correctly, that this route does not exist anymore?
There was a problem hiding this comment.
The backend still provides this route for old clients, but the frontend doesn’t use it anymore (was replaced by getReadableAnnotations)
frcroth
reviewed
Jan 17, 2024
Comment on lines
+310
to
+311
| // In dashboard, list only own + explicitly shared annotations. When listing those of another user, list all of their annotations the viewer is allowed to see | ||
| isForOwnDashboard: Boolean, |
There was a problem hiding this comment.
Suggested change
| // In dashboard, list only own + explicitly shared annotations. When listing those of another user, list all of their annotations the viewer is allowed to see | |
| isForOwnDashboard: Boolean, | |
| // In dashboard, list only own + explicitly shared annotations. When listing those of another user, list all of their annotations the viewer is allowed to see | |
| isForOwnDashboard: Boolean, |
I find the naming here to be too closely linked with the intent and not with what actually happens. Also surprising behavior when the function is called findAllListable and the parameter gives no hint on that the result may change. Maybe more like filterOwnedAndExplicitlyShared
There was a problem hiding this comment.
I agree, wrote #7565 to track that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed a bug where listing the annotations of other users would result in empty lists even if there are annotations and you should be allowed to see them.
URL of deployed dev instance (used for testing):
Steps to test:
Context