Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix crash in proofreading when no meshes existed before #7534

Merged
merged 3 commits into from
Jan 9, 2024
Merged

Fix crash in proofreading when no meshes existed before #7534

merged 3 commits into from
Jan 9, 2024

Conversation

philippotto
Copy link
Member

@philippotto philippotto commented Jan 9, 2024 •
edited by daniel-wer
Loading

URL of deployed dev instance (used for testing):

Steps to test:

  • open an annotation with an agglomerate mapping
  • select a mapping
  • select proofreading tool
  • disable automatic mesh loading in toolbar
  • merge two segments

Issues:

@philippotto philippotto self-assigned this Jan 9, 2024
daniel-wer
daniel-wer approved these changes Jan 9, 2024
View reviewed changes
Copy link
Member

@daniel-wer daniel-wer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@philippotto philippotto enabled auto-merge (squash) January 9, 2024 17:24
@philippotto philippotto merged commit 883f955 into master Jan 9, 2024
2 checks passed
@philippotto philippotto deleted the fix-crash-in-proofreading branch January 9, 2024 17:42
@valentin-pinkau valentin-pinkau mentioned this pull request Jan 10, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daniel-wer daniel-wer daniel-wer approved these changes

Assignees

@philippotto philippotto

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@philippotto @daniel-wer