Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix that tree ids around 1023 are invisible on some GPUs #7443

Merged
merged 10 commits into from
Nov 17, 2023
Merged

Fix that tree ids around 1023 are invisible on some GPUs #7443

merged 10 commits into from
Nov 17, 2023

Conversation

philippotto
Copy link
Member

@philippotto philippotto commented Nov 16, 2023 •
edited
Loading

Use texelFetch so that the integer-based indices don't need to be converted to float first. This seems to resolve the issues we saw on some GPUs.

URL of deployed dev instance (used for testing):

Steps to test:

  • tested by @fm3 here
  • doublecheck that data layers render as usual

Issues:

@philippotto philippotto self-assigned this Nov 16, 2023
@philippotto philippotto merged commit f3c4dc4 into master Nov 17, 2023
2 checks passed
@philippotto philippotto deleted the debug-invisible-trees branch November 17, 2023 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@normanrz normanrz normanrz approved these changes

@daniel-wer daniel-wer Awaiting requested review from daniel-wer

Assignees

@philippotto philippotto

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@philippotto @normanrz