Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read Segment Index Files, Segment Stats for Annot. w/ FallbackL. #7437

Merged
merged 117 commits into from
Mar 18, 2024

Conversation

frcroth
Copy link
Member

@frcroth frcroth commented Nov 13, 2023

URL of deployed dev instance (used for testing):

  • https://___.webknossos.xyz

Steps to test:

  • Test the datastore routes segmentIndex, segmentVolume and boundingBox (test with l4_sample)
  • Test the fallback behavior: When a volume tracing has a fallback, it will by default return the segment file index. Once something changed in the corresponding buckets by annotating, all affected segments will be queried from the mutable segment index

TODOs:

  • Test Scenario 1
    • Create a volume tracing annotation for a dataset with segmentation layer using that as fallback layer
    • The tracing has "hasSegmentIndex" true
    • When annotating a new segment, fossilDB is filled with content
    • When querying segment volume for the new segment, the correct/a sensible value is returned
    • When querying a segment volume for a segment in the file, the correct value is returned
    • Select an existing segment id, annotate
    • Now the segment volume is the one you just annotated
  • A lot of things are marked as TODO
  • The delete segment data action should be limited to segments smaller than x buckets -> Followup?
  • Handle ds without mag 1
  • Bounding Box
  • additional coords -> Followup?
  • Create simple test dataset
  • Speed up saving

TODOs frontend:

  • use datastore host if no volume annotation layer is visible (cases: no annotation or skeleton-only annotation)
  • remove code duplication by finding out where to put helper method (context menu and stats modal)
  • make sure the right conditions are tested
  • find out whether meshes should use index file in dataview mode

Followups

Issues:


  • Updated changelog
  • Needs datastore update after deployment

@frcroth frcroth self-assigned this Dec 11, 2023
@frcroth frcroth requested a review from fm3 January 10, 2024 11:57
@fm3 fm3 changed the title WIP: Add route to read segment index file WIP: Read Segment Index Files, Provide Segment Stats for Volume Annotations With Fallback Layer Jan 15, 2024
Copy link
Member

@fm3 fm3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@frcroth I fixed a couple of cases and re-tested. It looks good to me now. Please have a look at my latest commits and if you think this is now ready, feel free to merge on monday when you return :)

Copy link
Member

@philippotto philippotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

front-end looks good, too :) only left a comment about one variable name..

@frcroth frcroth changed the title Read Segment Index Files, Provide Segment Stats for Volume Annotations With Fallback Layer Read Segment Index Files, Segment Stats for Annot. w/ FallbackL. Mar 18, 2024
@frcroth frcroth merged commit 9a86c29 into master Mar 18, 2024
2 checks passed
@frcroth frcroth deleted the segment-index-file branch March 18, 2024 09:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

segment-to-bucket index for volume annotations *with fallback segmentation*
4 participants