-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move maintenance banner to top of the screen #7421
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great stuff 🎉 I like the CSS solution and also the refactoring of the component.
Besides my few comments, I noticed that the ArbitraryView
didn't get a listener (like the PlaneView
did) even though it uses getGroundTruthLayoutRect
. Probably needs to be added?
Co-authored-by: Philipp Otto <philippotto@users.noreply.github.com>
Co-authored-by: Philipp Otto <philippotto@users.noreply.github.com>
Co-authored-by: Philipp Otto <philippotto@users.noreply.github.com>
Good call. Thanks I overlooked this one and will add it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works very well 👍 Thank you for investing time in this 🥇
This PR moves the maintenance banner to the very top of the screen as part of the navbar so it does not interfere with other menus / buttons / tabs etc.
The CSS remains mostly untouched. The trick was to use real CSS variables for the navbar height instead of just a LESS variable. These CSS variables can be modified in (JS) code and then the rest of the styles just adapt.
Additionally the current navbar height is also saved in the stored and can be referenced in different downstream methods that used a constant instead.
I also refactored the maintenance banner component a little bit to more clearly separate the data/state from the rendering of the component.
URL of deployed dev instance (used for testing):
Steps to test:
Issues:
(Please delete unneeded items, merge only when none are left open)