-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Explore Neuroglancer URIs #7416
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good :)
I tried with some examples from here https://github.com/google/neuroglancer#examples but always got Received invalid URI
in the explore report. Maybe it has something to do with url encoding? I have a l ot of %7B%22
in the uris. Can you reproduce that? (I clicked open viewer, waited till the neuroglancer page is loaded, then copied the uri from the firefox address bar)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, looks like that was in fact an illegal URI (double hash sign). I’d say it’s fair that we can’t take those for the moment.
URL of deployed dev instance (used for testing):
Steps to test:
TODOs:
Respect credentials--> Fail on credentialsNote: Some of the examples at neuroglancer can't be imported because they use URIs that are not standard-compliant, which causes an exception in the java.net.URI implementation. Specifically, that is because there are multiple number signs (#), where only one is allowed. For example, this fails.
Issues:
(Please delete unneeded items, merge only when none are left open)