Support 2d ome zarr #7349
Support 2d ome zarr #7349
Conversation
There was a problem hiding this comment.
Thanks for fighting your way through this!
Do you think it would be a lot of effort to change it to a single case class AxisOrder with an optional z, instead of the two classes with the abstract one on top?
Then, wherever you have the match pattern now, we could have if (axisOrder.hasZAxis) {} else {}. Also, we would get the json format for free.
webknossos-datastore/app/com/scalableminds/webknossos/datastore/datareaders/AxisOrder.scala
Outdated
Show resolved
Hide resolved
| @@ -30,11 +30,35 @@ class DatasetArray(vaultPath: VaultPath, | |||
|
|
|||
| protected lazy val chunkReader: ChunkReader = new ChunkReader(header) | |||
|
|
|||
| // Helper variables to allow reading 2d datasets as 3d datasets with depth 1 | |||
There was a problem hiding this comment.
Could you also add a comment in the header definition mentioning this? We might in the future want to use a value from the header class, and should instead look here.
webknossos-datastore/app/com/scalableminds/webknossos/datastore/datareaders/DatasetArray.scala
Show resolved
Hide resolved
|
Does readBytesWithAdditionalCoordinates also have to be adapted? 🤔 |
Looking at it I guess not, is this in scope of this PR? |
URL of deployed dev instance (used for testing):
Tested for one dataset with channels and without.
Steps to test:
Issues:
(Please delete unneeded items, merge only when none are left open)