Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to expand and collapse all children of segment group #7911

Merged
merged 17 commits into from
Jul 23, 2024

Conversation

dieknolle3333
Copy link
Contributor

@dieknolle3333 dieknolle3333 commented Jul 1, 2024

Dev instance

https://collapseallsegmentgroupchildren.webknossos.xyz/

Steps to test:

  • go to segments tab in any annotation
  • click some segments and create some groups, groups should be nested for at least three levels
  • right click any group to access group context menu
  • if the segment group has any subgroups, there should be one or two new items: "expand/collapse all subgroups".
  • if the group is expanded and some subgroups are expanded and some are collapsed, both entries should be shown
  • if the group itself is expanded and all subgroups are collapsed, you should only be able to expand them. the opposite is true if all subgroups are expanded.
  • if the group itself is collapsed, you should only be able to expand all subgroups. the group itself will be expanded aswell.
    - # 7827: Focus in segment list should also work for segments in a collapsed group

TODOs:

  • icon
  • switch label
  • default: all expanded
  • recursively expand subgroups

Issues:


(Please delete unneeded items, merge only when none are left open)

@dieknolle3333 dieknolle3333 self-assigned this Jul 2, 2024
@dieknolle3333 dieknolle3333 changed the title WIP: add option to expand and collable all children of segment group WIP: add option to expand and collapse all children of segment group Jul 8, 2024
@dieknolle3333 dieknolle3333 marked this pull request as ready for review July 9, 2024 16:46
@dieknolle3333 dieknolle3333 changed the title WIP: add option to expand and collapse all children of segment group Add option to expand and collapse all children of segment group Jul 10, 2024
@dieknolle3333
Copy link
Contributor Author

dieknolle3333 commented Jul 10, 2024

I decided to work on #7827 here because I need the changes that are made in this PR and I think it's only a small change to solve this issue.

@dieknolle3333 dieknolle3333 marked this pull request as draft July 10, 2024 13:47
@dieknolle3333 dieknolle3333 marked this pull request as ready for review July 10, 2024 14:04
Copy link
Member

@philippotto philippotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool, looks good overall! just see my few comments.

Copy link
Member

@philippotto philippotto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, works well 👍

@dieknolle3333 dieknolle3333 enabled auto-merge (squash) July 23, 2024 09:07
@dieknolle3333 dieknolle3333 merged commit b588729 into master Jul 23, 2024
2 checks passed
@dieknolle3333 dieknolle3333 deleted the collapse-all-segment-group-children branch July 23, 2024 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Collapse subgroups under any higher order group in the segment list
2 participants