Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use protobufjs-cli package once it is released #5234

Open
daniel-wer opened this issue Mar 3, 2021 · 1 comment
Open

Use protobufjs-cli package once it is released #5234

daniel-wer opened this issue Mar 3, 2021 · 1 comment
Labels

Comments

@daniel-wer
Copy link
Member

Executing the tests locally (yarn test) fails, because protobufjs internally calls npm install to install some dependencies. In the past we've included these dependencies in our own devDependencies but this breaks without notice if protobufjs adds new dependencies and is confusing. They have recognized this as the dark pattern causing problems that it is and will release a separate protobufjs-cli package which includes these dependencies. Let's switch to that once it becomes available.

@daniel-wer
Copy link
Member Author

Apparently protobufjs-cli is still not properly released, see this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant