Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to NextJS App router #526

Closed
carletex opened this issue Sep 7, 2023 · 4 comments · Fixed by #535
Closed

Migrate to NextJS App router #526

carletex opened this issue Sep 7, 2023 · 4 comments · Fixed by #535
Assignees

Comments

@carletex
Copy link
Member

carletex commented Sep 7, 2023

I tried it when we migrated to NextJS v13, but it was in beta and I was getting a bunch hard-to-debug errors. It seems more stable now.

It's the path they are taking, so I think we should migrate to be able (us & builders) to use the current features (client / server components, server actions, etc) and future ones.

https://nextjs.org/docs/app
Upgrade pages => app router: https://nextjs.org/docs/app/building-your-application/upgrading/app-router-migration

What do you all think?

@Anurag-Raut
Copy link
Contributor

Anurag-Raut commented Sep 13, 2023

I was migrating my personal project from page to app router which is using scaffold-eth-2 , thought i could help migrate scaffold-eth-2 as well.

If anyone else isn't working on it , can I ?

@carletex
Copy link
Member Author

Sure @Anurag-Raut !

Feel free to draft a PR when ready.

Thanks!! <3

@Anurag-Raut
Copy link
Contributor

Anurag-Raut commented Sep 14, 2023

@carletex we are currently using next v13.1.6 ,should we upgrade to next v13.4 since app router has became stable from v13.4

also if we decided to stick with the current version of next (v13.1.6) we would need to use app Router in experimental mode .

@carletex
Copy link
Member Author

@Anurag-Raut yest! Let's update to the latest NextJS version.

Thanks

@Anurag-Raut Anurag-Raut mentioned this issue Sep 14, 2023
2 tasks
@carletex carletex linked a pull request Sep 14, 2023 that will close this issue
2 tasks
@technophile-04 technophile-04 mentioned this issue Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants