Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split torch ops into separate files #30

Merged
merged 1 commit into from
Jun 18, 2023
Merged

Split torch ops into separate files #30

merged 1 commit into from
Jun 18, 2023

Conversation

davoclavo
Copy link
Contributor

@davoclavo davoclavo commented Jun 18, 2023 •
edited
Loading

Fixes #29

Bonus additions:

  • Add torch.multinomial [RandomSamplingOps]
  • Add torch.randint [RandomSamplingOps]
  • Add torch.gradient [PointwiseOps]
  • Add torch.nn.functional.oneHot

@davoclavo
Split torch ops into separate files
bfa2d14 
Fixes sbrunk#29

Bonus additions:

- Add `torch.multinomial` [RandomSamplingOps]
- Add `torch.randint` [RandomSamplingOps]
- Add `torch.gradient` [PointwiseOps]
- Add `torch.nn.functional.oneHot`
@davoclavo
Copy link
Contributor Author

@sbrunk I think these changes will cause merge conflicts with your new additions in #28, my apologies! - I can cherry pick your commit and resolve them in this branch, or merge this first and then help you resolve them in your branch, feel free to let me know 👷🏼‍♂️

@davoclavo davoclavo marked this pull request as ready for review June 18, 2023 06:16
@sbrunk sbrunk self-requested a review June 18, 2023 09:32
@sbrunk
Copy link
Owner

sbrunk commented Jun 18, 2023

Thanks so much @davoclavo! No worries, I'll just rebase and resolve any conflicts.

@sbrunk sbrunk merged commit 4d8a82f into sbrunk:main Jun 18, 2023
@sbrunk sbrunk mentioned this pull request Jun 18, 2023
Closed
@davoclavo davoclavo deleted the tensor_ops_refactor branch June 19, 2023 00:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sbrunk sbrunk Awaiting requested review from sbrunk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move op methods into dedicated objects and export them to torch namespace
2 participants
@davoclavo @sbrunk