Fix torch.randn to use proper native function #27
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix subtle bug with
torch.randn
, as it was mistakenly usingrand
under the hood.I tried implementing a variance check as well, but I couldn't find the
var
function under javacpp. If anyone is able to help me I'd appreciate it.As a side note, I will keep implementing more tensor ops soon, and improving test coverage to try to avoid these kind of subtle errors; a handful of them happened to me while implementing pointwise ops.