Clone native tensor to avoid having buffers with corrupted data

fixes #25 Co-authored-by: Sören Brunk <soeren@brunk.io>
sbrunk · Jun 15, 2023 · 0f470d7 · 0f470d7
1 parent 3fb3c5d
commit 0f470d7
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 0 deletions.
diff --git a/core/src/main/scala/torch/Tensor.scala b/core/src/main/scala/torch/Tensor.scala
@@ -797,6 +797,7 @@ object Tensor:
               Array(data.length.toLong),
               NativeConverters.tensorOptions(inputDType, layout, CPU, requiresGrad)
             )
+            .clone()
         ).to(device = device)
       case data: U =>
         val dtype = scalaToDType(data)

diff --git a/core/src/test/scala/torch/TensorSuite.scala b/core/src/test/scala/torch/TensorSuite.scala
@@ -884,4 +884,17 @@ class TensorSuite extends TensorCheckSuite {
     ),
     expectedTensor = Tensor(Seq(0.0, 0.0, 0.0, 0.0, Double.NaN))
   )
+  test("Tensor creation properly handling buffers") {
+    val value = 100L
+    val data = Seq.fill(10000)(value)
+    val tensors = 1.to(1000).map { _ =>
+      Tensor(data)
+    }
+    assert(
+      tensors.forall { t =>
+        t.min().item == value &&
+        t.max().item == value
+      }
+    )
+  }
 }