rename Savon::Response#hash #985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Olle Jonsson <olle.jonsson@gmail.com>
|
I renamed it to so it will be |
motske
pushed a commit
to motske/savon
that referenced
this pull request
Sep 5, 2024
* rename Savon::Response#hash to Savon::Response#full_hash * fix tests so they pass in both rack 2 and rack 3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change is this?
make sure we don't unintentionally clobber Object#hash in
Savon::ResponseclassDid you add tests for your changes?
existing tests updated to reflect the new name
Summary of changes
Savon::Response#response_hashto_hashwas already taken, and means something totally different (its an alias forSavon::Response#body). i could've doneto_hbut that feels confusingfull_hash?hashmethod on Savon::Response #950 for motivation