New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Store data on disk (electron) #23

Closed

andywer opened this issue Jun 21, 2018 · 1 comment

Labels

Milestone

MVP - Minimum Via...

Contributor

andywer commented Jun 21, 2018 •

edited

Loading

As a user I want my keys to be securely stored on my local disk.

Have a look at: https://github.com/sindresorhus/electron-store

andywer added the user story label

andywer added this to the MVP - Minimum Viable Product milestone

andywer added tech story and removed user story labels

Contributor Author

andywer commented Aug 2, 2018

For comparison: Stargazer saves the keys in the underlying Chrome's local storage. See https://github.com/future-tense/stargazer/blob/master/app/core/services/storage.js#L4.

Unprofessional as that sounds first, it might even be a useable solution. But when googling https://www.google.de/search?q=electron+local+storage+limitations&oq=electron+local+storage+limitations&aqs=chrome..69i57j0.479j0j7&sourceid=chrome&ie=UTF-8 and reading sindresorhus/electron-store#17 I get the feeling that local storage is not the place keys should go.

andywer mentioned this issue

Store keys on disk #82

Merged

andywer closed this as completed in #82

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment