Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Electron exception when pressing update notification twice #1110

Closed
andywer opened this issue Jul 8, 2020 · 1 comment · Fixed by #1111
Closed

Electron exception when pressing update notification twice #1110

andywer opened this issue Jul 8, 2020 · 1 comment · Fixed by #1111
Assignees
Labels
bug Something isn't working

Comments

@andywer
Copy link
Contributor

andywer commented Jul 8, 2020

As seen on Windows:
"I hit update in the notification and after a while, because nothing happened, again by pressing update next to the settings button above." (as reported by Alex)

It's of course also sub-optimal that the user cannot see the update progress.

image

@andywer andywer added the bug Something isn't working label Jul 8, 2020
@ebma
Copy link
Member

ebma commented Jul 13, 2020

There is not much we can do about the update progress issue because the build-in electron autoUpdater does not offer subscribing to the download progress. The electron-builder one does but IIRC we had issues with that (and it had some security issues) so I would opt for not switching back to it.

And in general the user should not be able to press the update button twice as long as he does not manually reload the page/app but we cannot prevent that because we cannot check if the update is already running (we can only listen to that error which is thrown after starting it twice).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants