Skip to content

Latest commit

 

History

History
37 lines (23 loc) · 2.9 KB

VISION.md

File metadata and controls

37 lines (23 loc) · 2.9 KB
Raw

Danger for JS

Danger JS is a tool to creating complex per-project rules, and messages in Code Review. One of it's key aims is to be able to run on a server, and not need direct access to the filesystem to do its work.

It was started in mid-2016, and has fleshed out into a considerable set of useful tools.

  • You can fake running on CI for any PR with danger pr.
  • You can run Danger rules inside git hooks, or without pull requests metadata via danger local.
  • You can share code using danger plugins.
  • You can get started in a fun way via danger init.
  • Danger can run independently of CI via Peril.

Future Plans

There are only really two big targets for the future of Danger JS:

  • Inline comments in PRs
  • GitLab / BitBucket support

I don't plan on really using either of those features, so I expect both to come from the community instead.

My focus is going to be mainly in the Peril side of Danger. Moving to making it trivial to add Danger to any GitHub project and really unlocking some complex culture systems. Examples of these can be found on the Artsy blog.

Why Danger JS? What about Danger Ruby?

When I started Danger JS, Danger Ruby was two years old, is still doing just fine. See the original vision file. This document assumes you have read it.

The amount of issues we get in comparison to the number of downloads on Rubygems makes me feel pretty confident about Danger Ruby's state of production quality and maturity. I wanted to start thinking about the larger patterns in software, because at Artsy, we are starting to use JavaScript in for many teams.

I've explored running JavaScript from the ruby Danger, (example from production) but this pattern isn't going to work on the larger scale: You cannot use npm modules, nor work with babel/tsc to transpile your Dangerfile.js and the requirements on the integrating project to feel weird. Running JS in Ruby isn't going to work for me.

This realization came at the same time as serious thinking on a hosted version of Danger. With a JavaScript versions we can limit the exposed Danger DSL to only something that can be obtained over the API remotely. By doing this, a hosted Danger does not need to clone and run the associated projects. This is essential for my sanity. I cannot run multiple servers like CocoaDocs. So far, I'm calling this Peril. You can consult the vision file for Peril if you'd like.