Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error/failure when uploading a cache that already exists #85

Closed
rcowsill opened this issue Dec 7, 2020 · 0 comments · Fixed by #90
Closed

Error/failure when uploading a cache that already exists #85

rcowsill opened this issue Dec 7, 2020 · 0 comments · Fixed by #90
Labels
bug Something isn't working

Comments

@rcowsill
Copy link
Contributor

rcowsill commented Dec 7, 2020

Describe the bug
The post step is marked as failed when attempting to upload a cache that already exists.

It looks like the cache API is now returning a different error message when the cache already exists. It used to say:

Cache already exists: Error: reserveCache failed: Cache already exists. Scope: [...], Key: [...], Version: [...]

Now it says:

Error: Unexpected error: ReserveCacheError: Unable to reserve cache with key [...], another job may be creating this cache.

The LayerCache searches for "Cache already exists" in error messages to ignore that case, but the new message doesn't match that.

To Reproduce

  1. Run a workflow using this action to cache docker layers
  2. Push a change that will cause some new layers to build
  3. Run the workflow again with the same cache keys
  4. Observe the error message when already-cached files are uploaded

Expected behavior
Action to detect the new Unable to reserve cache and treat it as non-fatal.

Debug logs
https://github.com/satackey/action-docker-layer-caching/runs/1507974881

Runner Environment (please complete the following information):

  • OS: ubuntu-18.04
  • Action version: v0.0.10
@rcowsill rcowsill added the bug Something isn't working label Dec 7, 2020
@rcowsill rcowsill changed the title Actions Cache API error message changed Error/failure when uploading a cache that already exists Dec 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant