Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce concurrency when storing and restoring layers #12

Closed
dhadka opened this issue Aug 3, 2020 · 3 comments
Closed

Reduce concurrency when storing and restoring layers #12

dhadka opened this issue Aug 3, 2020 · 3 comments
Labels
bug Something isn't working

Comments

@dhadka
Copy link

dhadka commented Aug 3, 2020

Describe the bug

storeLayers and restoreLayers should limit the number of concurrent calls to the cache service, otherwise it can hit throttling limits. Right now, this action processes all layers in parallel, resulting in a large number of calls to the cache service in a very short time period.

To Reproduce
I don't have a good repro, but we have seen at least one user of this action try to cache 200+ layers. Those requests are all sent within about 0.1 seconds :)

Expected behavior

The action should limit the number of concurrent store / restore requests to the cache service.

Debug logs
N/A

Runner Environment (please complete the following information):

  • OS: Any
  • Action version: v0.0.4

Additional context

@dhadka dhadka added the bug Something isn't working label Aug 3, 2020
@dhadka dhadka changed the title Reduce concurrency when storing layers Reduce concurrency when storing and restoring layers Aug 3, 2020
@satackey
Copy link
Owner

satackey commented Aug 4, 2020

Sorry for the overloaded API request.
I will work on this soon.

@NoamDev
Copy link

NoamDev commented Aug 9, 2020

@dhadka Version 0.0.5 should solve this.

@dhadka
Copy link
Author

dhadka commented Aug 9, 2020

@NoamDev @satackey Perfect, thank you for the quick turnaround!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants