Skip to content
This repository has been archived by the owner on Jul 24, 2024. It is now read-only.

Disable all tests with --watch #1216

Closed
wants to merge 1 commit into from
Closed

Disable all tests with --watch #1216

wants to merge 1 commit into from

Conversation

saper
Copy link
Member

@saper saper commented Oct 24, 2015

Testing cli this way is completely
unreliable. A new method of testing
is needed.

Testing cli this way is completely
unreliable. A new method of testing
is needed.
@xzyfer
Copy link
Contributor

xzyfer commented Oct 25, 2015

👍
On 25 Oct 2015 8:20 am, "Marcin Cieślak" notifications@github.com wrote:

Testing cli this way is completely
unreliable. A new method of testing

is needed.

You can view, comment on, or merge this pull request online at:

#1216
Commit Summary

  • Disable all tests with --watch

File Changes

Patch Links:


Reply to this email directly or view it on GitHub
#1216.

@xzyfer
Copy link
Contributor

xzyfer commented Oct 27, 2015

Looks like you missed one?

 1) cli "before all" hook for "should return a correct version info":
     Error: timeout of 2000ms exceeded. Ensure the done() callback is being called in this test.
      at null.<anonymous> (C:\projects\node-sass\node_modules\mocha\lib\runnable.js:189:19)

@saper
Copy link
Member Author

saper commented Oct 29, 2015

Looks like node 5.x has watching broken on my favourite OS nodejs/node#3541

@saper
Copy link
Member Author

saper commented Oct 29, 2015

this before all hook checking libsass version must be rewritten in an async way. Will fix of course.

@xzyfer xzyfer added this to the next.patch milestone Oct 31, 2015
@xzyfer
Copy link
Contributor

xzyfer commented Dec 27, 2015

I believe this has been done.

@xzyfer xzyfer closed this Dec 27, 2015
@saper saper mentioned this pull request Feb 14, 2016
@xzyfer xzyfer modified the milestone: next.patch Sep 4, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants