Fix @import url("...") in plain CSS
#2398
Conversation
nex3
force-pushed
the
import-quoted-url
branch
from
ae1aa3a
to
247f959
Compare
| $u || $U => dynamicUrl() as StringExpression, | ||
| $u || $U => switch (dynamicUrl()) { | ||
| StringExpression string => string.text, | ||
| InterpolatedFunctionExpression( |
There was a problem hiding this comment.
I think this would work for most of the cases. However, this would attempt to parse a "interpolated" string. In pure css, technically I can do @import url("a.css#{url-with-a-weird-hash}"); and it should still be valid, but I suppose this will throw interpolation is not allowed in css?
There was a problem hiding this comment.
In other words, strings in plain css should probably never be parsed as interpolated, even if they contain sass interpolation syntax.
There was a problem hiding this comment.
This code isn't actually parsing anything, it's just handling the various formats that the dynamicUrl() function can return. But yes, interpolations will throw errors in plain CSS mode even when they are technically valid CSS—largely because LibSass incorrectly interpreted .css files as SCSS, so we want to highlight places where that's not working. It might be worth revisiting that decision for Dart Sass 3.0.0, but probably not for 2.0.0.
Closes #2397
See sass/sass-spec#2033