Emit all warnings in the evaluator #2396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nex3
approved these changes
Oct 18, 2024
| "Relative canonical URLs are deprecated and will eventually be " | ||
| "disallowed."); | ||
| } else if (await importer.isNonCanonicalScheme(result.scheme)) { | ||
| if (result.scheme != '' && |
There was a problem hiding this comment.
Add a comment that this should be an error but currently produces a deprecation warning in the evaluator
lib/src/parse/stylesheet.dart
Outdated
| @@ -119,25 +123,32 @@ abstract class StylesheetParser extends Parser { | |||
| return arguments; | |||
| }); | |||
|
|
|||
| Expression parseExpression() => _parseSingleProduction(_expression); | |||
| ({Expression node, List<ParseTimeWarning> warnings}) parseExpression() => | |||
There was a problem hiding this comment.
I'd make the return value positional, since there are only two values with no risk of confusion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2390.
This changes the parser to store all warnings it would emit in the
warningsfield on the parsed stylesheet, which are then all emitted when that stylesheet is visited by the evaluator. This eliminates the need to wrap and pass loggers to the parser andImportCacheand ensures that the various deprecation warnings are handled consistently by theDeprecationProcessingLoggercreated for each evaluation.See sass/sass-spec#2032.