Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the version of Sass used by the website on release #2102

Merged
merged 2 commits into from
Sep 30, 2023
Merged

Conversation

nex3
Copy link
Contributor

@nex3 nex3 commented Sep 28, 2023

No description provided.

@nex3 nex3 requested a review from jathak September 28, 2023 22:40
jq --arg version ^${{ steps.version.outputs.version }} '
.devDependencies.sass |= $version
' > package.json.tmp
mv package.json.tmp package.json
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As there is a committed lock file, this won't be enough

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can run npm update sass after that, which should update only sass in the package-lock.json.

However, this job should depends on deploy_npm so that it's updated only after npm package has been published.

@nex3 nex3 merged commit 4255930 into main Sep 30, 2023
44 checks passed
@nex3 nex3 deleted the bump-sass-in-site branch September 30, 2023 00:12
jgerigmeyer added a commit to oddbird/dart-sass that referenced this pull request Oct 12, 2023
* feature.color-4: (30 commits)
  Update for `lch()` tests (sass#2108)
  Add support for relative color syntax (sass#2112)
  Update for `oklab()` tests (sass#2094)
  Poke CI
  Cut a release (sass#2107)
  Implement first class mixins (sass#2073)
  Fix a race condition preventing embedded compiler to shutdown after a protocol error (sass#2106)
  Switch to the GitHub-hosted MacOS ARM64 runner (sass#2103)
  Update the version of Sass used by the website on release (sass#2102)
  Bump actions/checkout from 3 to 4 (sass#2088)
  Bump docker/setup-qemu-action from 2 to 3 (sass#2089)
  Implement support for the relative color syntax of CSS Color 5 (sass#2098)
  Rephrase errors for numbers that must be unitless or % (sass#2101)
  Forbid LLM contributions (sass#2100)
  Update protocol-version during embedded-host-node release (sass#2097)
  Deprecate Deprecation.calcInterp (sass#2096)
  Avoid useless allocations for interpolations without maps (sass#2095)
  Fix an error during embedded compiler shutdown (sass#2092)
  Cut a release (sass#2090)
  Expose the containing URL to importers under some circumstances (sass#2083)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants