Don't emit warnings for plain-CSS invert() (#2394)

Fixes sass/sass#3963. Fixes #2393.
sass · Oct 17, 2024 · 2ad2133 · 2ad2133
1 parent e6391d3
commit 2ad2133
Show file tree

Hide file tree

Showing 7 changed files with 23 additions and 7 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -1,3 +1,8 @@
+## 1.80.2
+
+* Fix a bug where deprecation warnings were incorrectly emitted for the
+  plain-CSS `invert()` function.
+
 ## 1.80.1
 
 * Fix a bug where repeated deprecation warnings were not automatically limited.

diff --git a/lib/src/functions/color.dart b/lib/src/functions/color.dart
@@ -55,9 +55,12 @@ final global = UnmodifiableListView([
         space: ColorSpace.rgb, name: 'channels')
   }),
 
-  _function("invert", r"$color, $weight: 100%, $space: null",
-          (arguments) => _invert(arguments, global: true))
-      .withDeprecationWarning("color"),
+  _function("invert", r"$color, $weight: 100%, $space: null", (arguments) {
+    if (arguments[0] is! SassNumber && !arguments[0].isSpecialNumber) {
+      warnForGlobalBuiltIn("color", "invert");
+    }
+    return _invert(arguments, global: true);
+  }),
 
   // ### HSL
   _channelFunction("hue", ColorSpace.hsl, (color) => color.hue,

diff --git a/pkg/sass-parser/CHANGELOG.md b/pkg/sass-parser/CHANGELOG.md
@@ -1,3 +1,7 @@
+## 0.3.2
+
+* No user-visible changes.
+
 ## 0.3.1
 
 * No user-visible changes.

diff --git a/pkg/sass-parser/package.json b/pkg/sass-parser/package.json
@@ -1,6 +1,6 @@
 {
   "name": "sass-parser",
-  "version": "0.3.1",
+  "version": "0.3.2",
   "description": "A PostCSS-compatible wrapper of the official Sass parser",
   "repository": "sass/sass",
   "author": "Google Inc.",

diff --git a/pkg/sass_api/CHANGELOG.md b/pkg/sass_api/CHANGELOG.md
@@ -1,3 +1,7 @@
+## 13.1.2
+
+* No user-visible changes.
+
 ## 13.1.1
 
 * Make `AsyncImporterCache.wrapLogger()` and `ImporterCache.wrapLogger()` always

diff --git a/pkg/sass_api/pubspec.yaml b/pkg/sass_api/pubspec.yaml
@@ -2,15 +2,15 @@ name: sass_api
 # Note: Every time we add a new Sass AST node, we need to bump the *major*
 # version because it's a breaking change for anyone who's implementing the
 # visitor interface(s).
-version: 13.1.1
+version: 13.1.2
 description: Additional APIs for Dart Sass.
 homepage: https://github.com/sass/dart-sass
 
 environment:
   sdk: ">=3.0.0 <4.0.0"
 
 dependencies:
-  sass: 1.80.1
+  sass: 1.80.2
 
 dev_dependencies:
   dartdoc: ^8.0.14

diff --git a/pubspec.yaml b/pubspec.yaml
@@ -1,5 +1,5 @@
 name: sass
-version: 1.80.1
+version: 1.80.2
 description: A Sass implementation in Dart.
 homepage: https://github.com/sass/dart-sass