fix(cli): patch missing SYSTEMROOT
env var on windows
#4221
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
open
module tries to use theSYSTEMROOT
environment variable on Windows, which seems to (sometimes?) not exist. Some backgrounds here: sindresorhus/open#299Sindre seems unwilling to fix in the
open
module, so I figure we might as well implement a workaround for it since it currently causes issues for onboarding of new users on Windows (thelogin
action will fail when attempting to open a browser).Fixes #4195
Fixes #4194
[sc-30570]
What to review
Notes for release