Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): upgrade rxjs to v7 #80

Merged
merged 3 commits into from
Jan 4, 2023
Merged

fix(deps): upgrade rxjs to v7 #80

merged 3 commits into from
Jan 4, 2023

Conversation

bjoerge
Copy link
Member

@bjoerge bjoerge commented Jan 4, 2023

This upgrades rxjs from v6 to v7. This means that the observable instance returned from various client methods will now be an rxjs@v7 Observable. This should be a non-breaking since the Observable interface and behavior is from what I can tell largely kept intact between v6 => v7 (except for undocumented methods and a couple of minor type signature changes). In other words: a v6 Observable should be interoperable with a v7 Observable.

I set the range of the rxjs dependency to ^7.0.0 to aid deduping, and verified that the test suite passes against every minor of rxjs from v7.0.0 to v7.8.0.

Note: would prefer if the PR was rebase-merged since each individual commit makes sense on their own :)

@bjoerge bjoerge mentioned this pull request Jan 4, 2023
Copy link
Member

@stipsan stipsan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good to go 👍

@stipsan stipsan changed the title chore: upgrade rxjs to v7 fix(deps): upgrade rxjs to v7 Jan 4, 2023
@stipsan stipsan merged commit 594b4e7 into main Jan 4, 2023
@stipsan stipsan deleted the rxjs7 branch January 4, 2023 13:13
@github-actions
Copy link
Contributor

github-actions bot commented Jan 6, 2023

🎉 This PR is included in version 4.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants