Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(csm): add conditional isDraft search parameter to edit urls #604

Merged
merged 4 commits into from
Feb 26, 2024

Conversation

rdunk
Copy link
Member

@rdunk rdunk commented Feb 26, 2024

Adds an additional search parameter isDraft when constructing edit URLs if the given document is a draft.

Primarily used to more accurately report documents to Presentation tool, as we currently pass the document id as its published variant.

@rdunk rdunk requested a review from stipsan February 26, 2024 15:21
@rdunk rdunk marked this pull request as draft February 26, 2024 15:24
Copy link
Member

@stipsan stipsan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 🚀 🚀

@rdunk rdunk marked this pull request as ready for review February 26, 2024 16:23
@rdunk rdunk added this pull request to the merge queue Feb 26, 2024
Merged via the queue into main with commit 89783d2 Feb 26, 2024
15 checks passed
@rdunk rdunk deleted the feat/is-draft-in-edit-url branch February 26, 2024 16:34
@ecospark ecospark bot mentioned this pull request Feb 26, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants