Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

invalid condition module added to node export conditions #308

Closed
danielroe opened this issue Aug 24, 2023 · 0 comments · Fixed by #318
Closed

invalid condition module added to node export conditions #308

danielroe opened this issue Aug 24, 2023 · 0 comments · Fixed by #318

Comments

@danielroe
Copy link

danielroe commented Aug 24, 2023 •
edited
Loading

We're encountering an odd issue triggered by the following change to the node export conditions:

6ec1d7e

I'm not aware that the module condition is a valid condition (docs), and while it could be picked by a bundler, it is certainly not respected by node. Is there a reason it was added?
@danielroe danielroe mentioned this issue Aug 24, 2023
Closed
@stipsan stipsan mentioned this issue Sep 5, 2023
Merged
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@danielroe