fix: set useCdn: false automatically when perspective: 'previewDrafts'
#299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stipsan
commented
Aug 17, 2023
stipsan
force-pushed
the
set-use-cdn-to-false-on-preview-drafts
branch
from
87eea6e
to
0dca907
Compare
stipsan
commented
Aug 18, 2023
Comment on lines
+16
to
+17
| `The Sanity client is configured with the \`perspective\` set to \`previewDrafts\`, which doesn't support the API-CDN.`, | ||
| `The Live API will be used instead. Set \`useCdn: false\` in your configuration to hide this warning.`, |
There was a problem hiding this comment.
@rexxars does this look ok?
There was a problem hiding this comment.
Message looks okay to me - suggested a typo fix.
stipsan
force-pushed
the
set-use-cdn-to-false-on-preview-drafts
branch
from
0dca907
to
d9d60df
Compare
rexxars
reviewed
Aug 18, 2023
src/warnings.ts
Outdated
| @@ -12,6 +12,11 @@ export const printCdnWarning = createWarningPrinter([ | |||
| `\`useCdn: false\` to use the Live API. Note: You may incur higher costs using the live API.`, | |||
| ]) | |||
|
|
|||
| export const printCdnPrevieDraftsWarning = createWarningPrinter([ | |||
There was a problem hiding this comment.
Suggested change
| export const printCdnPrevieDraftsWarning = createWarningPrinter([ | |
| export const printCdnPreviewDraftsWarning = createWarningPrinter([ |
rexxars
reviewed
Aug 18, 2023
rexxars
approved these changes
Aug 18, 2023
Comment on lines
+16
to
+17
| `The Sanity client is configured with the \`perspective\` set to \`previewDrafts\`, which doesn't support the API-CDN.`, | ||
| `The Live API will be used instead. Set \`useCdn: false\` in your configuration to hide this warning.`, |
There was a problem hiding this comment.
Message looks okay to me - suggested a typo fix.
stipsan
force-pushed
the
set-use-cdn-to-false-on-preview-drafts
branch
from
d9d60df
to
4093b44
Compare
stipsan
force-pushed
the
set-use-cdn-to-false-on-preview-drafts
branch
from
4093b44
to
bbcbe96
Compare
|
🎉 This PR is included in version 6.4.9 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.