Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP 0.9: optimize, .. #4

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

WIP 0.9: optimize, .. #4

wants to merge 3 commits into from

Conversation

sanderland
Copy link
Owner

@sanderland sanderland commented Oct 18, 2022 •
edited
Loading

  • default formatter
  • optimize
  • breaking: heads get embeddings as last hidden state, not tuple outputs
  • regression on ints
    todo
  • encode on floats? perhaps warn or to str before

@sanderland sanderland changed the title optimize feature start 0.9: optimize, .. Oct 18, 2022
Mouhanedg56
Mouhanedg56 reviewed Oct 19, 2022
View reviewed changes
grouphug/model.py
if jit:
optimized_model = torch.jit.trace(optimized_model, tuple_input ,strict=False)
optimized_model = torch.jit.freeze(optimized_model)
setattr(self, self.base_model_prefix, optimized_model)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Where base_model_prefix is defined?

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

in the base huggingface models

grouphug/model.py Outdated Show resolved Hide resolved
grouphug/model.py Outdated Show resolved Hide resolved
grouphug/model.py Outdated Show resolved Hide resolved
Repository owner deleted a comment from Mouhanedg56 Oct 20, 2022
@sanderland sanderland changed the title 0.9: optimize, .. WIP 0.9: optimize, .. Oct 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mouhanedg56 Mouhanedg56 Mouhanedg56 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sanderland @Mouhanedg56