Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ActiveFedora should support jruby #24

Closed
jcoyne opened this issue Jan 7, 2013 · 4 comments
Closed

ActiveFedora should support jruby #24

jcoyne opened this issue Jan 7, 2013 · 4 comments

Comments

@jcoyne
Copy link
Member

jcoyne commented Jan 7, 2013

Formerly HYDRA-891

Broken test: rspec ./spec/integration/base_spec.rb:734

Blocked by this issue: sparklemotion/nokogiri#801

@ghost ghost assigned mbklein Jan 7, 2013
@jcoyne
Copy link
Member Author

jcoyne commented Jan 17, 2014

https://travis-ci.org/projecthydra/active_fedora/builds/16815008

Finished in 3 minutes 10.8 seconds
784 examples, 7 failures, 1 pending

Some of the failures are just whitespace differences in XML, but some are more worrisome:

  1) A base object with metadata a new document should save the datastream.
     Failure/Error: obj.foo.person.should == ['bob']
       expected: ["bob"]
            got: ["Author", "bob"] (using ==)

  2) A base object with metadata that already exists in the repo and has been changed should save the datastream.
     Failure/Error: MockAFBaseRelationship.find(@release.pid).foo.person.should == ['frank']
       expected: ["frank"]
            got: ["Author", "frank"] (using ==)

  5) ActiveFedora::OmDatastream.update_indexed_attributes should apply submitted hash to corresponding datastream field values
     Failure/Error: result.should == {"person_0_role"=>["role1", "role2", "role3"]}
       expected: {"person_0_role"=>["role1", "role2", "role3"]}
            got: {"person_0_role"=>["role2", "role2", "role3"]} (using ==)
       Diff:
       @@ -1,2 +1,2 @@
       -"person_0_role" => ["role1", "role2", "role3"]
       +"person_0_role" => ["role2", "role2", "role3"]

  6) ActiveFedora::OmDatastream.update_indexed_attributes should work for text fields
     Failure/Error: @mods_ds.get_values([{:person=>0},:description]).should == ['mork', 'york']
       expected: ["mork", "york"]
            got: [] (using ==)

  7) ActiveFedora::OmDatastream.update_indexed_attributes should allow deleting of values and should delete values so that to_xml does not return emtpy nodes
     Failure/Error: @mods_ds.get_values([{"person"=>"0"},"description"]).should == ['york', 'mangle', 'mork']
       expected: ["york", "mangle", "mork"]
            got: [] (using ==)

need to fix spec/integration/base_spec.rb and spec/unit/om_datastream_spec.rb

@jcoyne
Copy link
Member Author

jcoyne commented Jan 23, 2014

We are hitting this bug: sparklemotion/nokogiri#1034

jcoyne added a commit that referenced this issue Jan 26, 2015
jcoyne added a commit that referenced this issue Jan 26, 2015
@atz
Copy link
Contributor

atz commented Nov 6, 2015

This still a thing?

@jrgriffiniii
Copy link
Contributor

Greater than 10 years old, closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants