Remove fates dependency on do_harvest
#2
Conversation
|
TO DO:
|
|
Could you include an error in the build namelist step if it's a FATES compset but the user specifies |
Definitely. I had to switch tasks momentarily, but I should have this in before tomorrow. |
|
Making the This still needs a positive build and run check to make sure it isn't failing when it shouldn't. I'll also try using your brute force script. |
If luh + fbg are present fail if flandusepftdat isn't valid. Don't allow fluh_timeseries to be defined if in potential veg mode to avoid confusing users that it is needed.
|
This is building and running successfully. I created a spreadsheet with the output of the bruteforce script you providing in our email discussions that adds some columns with the checks we want to make sure pass or fail. Everything looks to be working as expected: https://docs.google.com/spreadsheets/d/11wSpoZvFji5TKjZWOIC3ILtmX4r6IyQgvfHsSo6pH6k/edit?usp=sharing |
migrating unit testing to folder unit_testing
Description of changes
As fates harvest modes have increased we should remove the dependency on
do_harvestto provide a clearer distinction between CLM and fates harvest mode types.Specific notes
The only remaining overlap between the host land model and fates is during the call to
dynHarvestInit, so we add a check on the fates harvest mode here.Testing performed, if any
Build and run test still needed