Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sanitize_url provokes issue with other plugin content-views-pro #74

Open
Wohlfarth opened this issue Apr 5, 2023 · 1 comment
Open

Comments

@Wohlfarth
Copy link

Hi @samiahmedsiddiqui
The commit 15b7cd4
in particular line 54 provokes an issue with our content views pro filter at https://www.internetsociety.org/blog/?tx_region_news_regions=africa
i.e. the select item will not stay selected and the content in the grid will not be updated.

Replacing class-custom-permalinks-frontend.php on line 54 sanitize_url by sanitize_text_field on your version 2.5.2 fixes the issue.

Can you create a fix?
Thank you very much!
Henri

@codemonkeynorth
Copy link

codemonkeynorth commented Sep 28, 2023

agreed

if the url / querystring is https://www.example.com?foo=bar

then sanitize_url($_SERVER['QUERY_STRING']) would return http://foo=bar.. it should just be foo=bar

I'm not sure if sanitize_text_field is the correct function to use though for this?

(update: checked and actually ChatGPT says it is, so thanks for the suggestion!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants