Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In Debian apache.config plays two opposite actions #285

Open
gaetanars opened this issue Oct 9, 2020 · 1 comment
Open

In Debian apache.config plays two opposite actions #285

gaetanars opened this issue Oct 9, 2020 · 1 comment

Comments

@gaetanars
Copy link
Contributor

gaetanars commented Oct 9, 2020

When I use apache or apache.config state on Debian system, each run had some modified files :
/etc/apache2/sites-available/000-default.conf

apache.config.own_default_vhost produce
Name: /etc/apache2/sites-available/000-default.conf - Function: file.managed - Result: Changed
and apache.config.debian_full produce :
Name: /etc/apache2/sites-available/000-default.conf - Function: file.absent - Result: Changed

Have I missed some pillars to block this double change or is that a bug in this formula?

Regards

@noelmcloughlin
Copy link
Member

noelmcloughlin commented Oct 10, 2020

I recently did a refactoring of this formula but did not add that code.

The file.absent state already existed in debian_full.sls file. If it is a bug and debian_full state is not doing anything useful - please consider raising a PR to remove that line from apache.config.init.sls and apache.config.clean files.

I do not know what òwn_default_vhostanddebian_full` states are for. If they are useful then updating the README to explain why would help. Since these are tiny PRs I hope you could contribute. thanks.

Here are the original lines before my last refactor PR.

/etc/apache2/sites-available/{{ apache.default_site }}:
  file.absent:
    - require:
      - pkg: apache
/etc/apache2/sites-available/{{ apache.default_site_ssl }}:
  file.absent:
    - require:
      - pkg: apache

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants