Skip to content
This repository has been archived by the owner on Feb 12, 2022. It is now read-only.

Why there are two times log_softmax in splitcross.py #97

Open
marcwww opened this issue Feb 28, 2019 · 2 comments
Open

Why there are two times log_softmax in splitcross.py #97

marcwww opened this issue Feb 28, 2019 · 2 comments

Comments

@marcwww
Copy link

marcwww commented Feb 28, 2019

It seems the tail_res go through log_softmax twice:
line 65
and
line 163.

What is the meaning behind it? Thanks a lot.
@lorelupo
Copy link

lorelupo commented Apr 5, 2019 •
edited
Loading

Hi @marcwww , I suspect it is an error as pointed out in #62 and #82 .

@marcwww
Copy link
Author

marcwww commented Apr 5, 2019

Hi @marcwww , I suspect it is an error as pointed out in #62 and #82 .

Thanks a lot. Hoping the author could fix it if it is indeed an error.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@marcwww @lorelupo