-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove mailpit checks in E2E tests #5211
Open
Cloud11PL
wants to merge
6
commits into
main
Choose a base branch
from
run-mailpit-tests-only-on-release
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+7
−61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 7b055d6 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
NyanKiyoshi
previously approved these changes
Oct 11, 2024
michalina-graczyk
previously approved these changes
Oct 14, 2024
Cloud11PL
dismissed stale reviews from michalina-graczyk and NyanKiyoshi
via
October 14, 2024 12:07
3e3dc96
Cloud11PL
force-pushed
the
run-mailpit-tests-only-on-release
branch
from
October 14, 2024 12:07
96d1336
to
3e3dc96
Compare
Cloud11PL
changed the title
Don't run export tests on PRs
Remove mailpit checks in E2E tests
Oct 14, 2024
poulch
approved these changes
Oct 15, 2024
NyanKiyoshi
approved these changes
Oct 15, 2024
andrzejewsky
approved these changes
Oct 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Related Issues or Documents
Usage Instructions, Screenshots, Recordings
Have you written tests?
[Optional] Description
Tests that export items tend to fail on PRs thus blocking merge but they always pass on release runs.