Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHP code being rendered in documentation #177

Closed
tnylea opened this issue Nov 3, 2019 · 7 comments
Closed

PHP code being rendered in documentation #177

tnylea opened this issue Nov 3, 2019 · 7 comments

Comments

@tnylea
Copy link

tnylea commented Nov 3, 2019

Describe the bug
When adding any blade directives inside of code blocks for my documentation, Larecipe tries to execute those code blocks as actual PHP code. If there is an undefined variable in the docs or a syntax error, the page will throw an error.

To Reproduce
Steps to reproduce the behavior:

  1. Add a blade directive such as @if to your .md file
  2. Try and view that documentation, you will get an error

Expected behavior
Expected Behavior would be to see the documentation file, but instead I get an error

Screenshots
Screen Shot 2019-11-03 at 12 35 54 PM

Desktop (please complete the following information):

  • OS: MacOS Mojave 10.14.4
  • Browser CHROME
  • Version 77.03

Additional context
I just upgraded to the latest version of Larecipe and this is happening now, it was not happening when I was using version 1.0.

If anyone could help me figure this out, I would really appreciate it :) Thanks!

@WillGoldstein
Copy link
Contributor

It’d be a nice to have but I wouldn’t say it’s a bug necessarily. Why are you needing to use blade syntax in markdown? Have you tried making your own vue component instead?

@telkins
Copy link
Contributor

telkins commented Nov 28, 2019

I'm not sure if this is related, but I'd like to pass in variables, so that I can use the same value across all my docs and quickly/easily change it if/when it's needed.

Is this possible...?

@telkins
Copy link
Contributor

telkins commented Nov 28, 2019

Of course, it may be that I'm looking for this: #138

Or both.... ;-)

@WillGoldstein
Copy link
Contributor

Gotchya, makes sense. Seems like that issue you referenced has a solution?

@telkins
Copy link
Contributor

telkins commented Dec 1, 2019

@WillGoldstein Well, it does provide a solution, but not one that I or at least one of the others here are terribly happy with. :-/

@WillGoldstein
Copy link
Contributor

@telkins indeed, perhaps I should have said “workaround” instead of “solution”

@saleem-hadad
Copy link
Owner

as for now, this issue fixed in v2.4.3
Screen Shot 2020-09-09 at 12 20 15 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants