Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FR: Support for GW ipadress #25

Closed
mburger81 opened this issue Aug 25, 2017 · 5 comments
Closed

FR: Support for GW ipadress #25

mburger81 opened this issue Aug 25, 2017 · 5 comments

Comments

@mburger81
Copy link

This plugin looks great, we would like to ask for a feature request on android and ios,

We need the ipaddress for the GW/Router the device is connected. I had a look on android and there is the possibility to do this, probably also on ios.

Could you have a look for it and integrate it.

FYI:
Perhaps if anything is working great, we would like in feature to propose to the ionic team to integrate this as ionic-native. If we find the time we can open a pull request on them. What do you think about it?

@salbahra
Copy link
Owner

Apologies for the delay. Yes if you have a pull request to include this feature I would be more than happy to include it. Also, I would love to integrate this with ionic-native if the team would like. Please let me know and we can work together to help make that happen.

Thanks!

@salbahra
Copy link
Owner

I went ahead and submitted a PR to @ionic-native/network-interface here: danielsogl/awesome-cordova-plugins#2063.

@salbahra
Copy link
Owner

The ionic-native plugin is now added and the readme documentation has been extended to include it.

@salbahra
Copy link
Owner

Looking at this fork, the router IP support seems to be added for both Android and iOS: https://github.com/tribe84/NetworkInterfacePlugin. If could, maybe review it and submit a PR? Otherwise I will try and take a look at this later. Thanks!

@salbahra
Copy link
Owner

salbahra commented Oct 6, 2021

Closing due to inactivity

@salbahra salbahra closed this as completed Oct 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants