Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

In 21.5+, external apps' internal ids are displayed instead of their externalAppName(s) #33

Open
austin48 opened this issue Mar 29, 2023 · 1 comment
Open

In 21.5+, external apps' internal ids are displayed instead of their externalAppName(s) #33

austin48 opened this issue Mar 29, 2023 · 1 comment

Comments

@austin48
Copy link
Contributor

  1. In Assignments or Samigo, create an assignment and send it to the gradebook
  2. Open Gradebook Classic
  3. the external app name is displayed as "sakai.assignment.grade" or "sakai.samigo"

I believe this was caused by to https://sakaiproject.atlassian.net/browse/SAK-47291

I have a potential fix for this but it also includes a change to edu-services. Let me know if I should create PR requests for both parts of the patch (edu-services and gradebook1)
@austin48
Copy link
Contributor Author

this will probably require a new GradebookAssignement variable like externalAppDisplayName

(note this would be in addition to externalAppName)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@austin48