Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test_size.test_invalid fails on x86 #522

Closed
sbraz opened this issue Sep 8, 2021 · 1 comment
Closed

test_size.test_invalid fails on x86 #522

sbraz opened this issue Sep 8, 2021 · 1 comment
Labels
bug

Comments

@sbraz
Copy link
Contributor

sbraz commented Sep 8, 2021

Hi,
I tried to run the test suite on an x86 chroot and one test fails:

test_size.test_invalid ... ('--size 0-18446744073709551616',) did not trigger an error exit.

I was able to confirm this by running rmlint --size 0-18446744073709551616 which indeed does not fail as excected.
sbraz added a commit to sbraz/rmlint that referenced this issue Sep 8, 2021
@sbraz
Fix max sizes on x86, closes sahib#522
87c53a5 
strtoull returns ULLONG_MAX, not ULONG_MAX.
sbraz added a commit to sbraz/rmlint that referenced this issue Sep 8, 2021
@sbraz
Fix max sizes on x86, part of the fix for sahib#522
fa1640e 
strtoull returns ULLONG_MAX, not ULONG_MAX.
@sbraz sbraz mentioned this issue Sep 8, 2021
Closed
@cebtenzzre cebtenzzre added the bug label Aug 15, 2022
@cebtenzzre
Copy link
Collaborator

This was fixed by 4043c79. It will be included in master soon.

@cebtenzzre cebtenzzre linked a pull request Aug 15, 2022 that will close this issue
Fix max sizes on x86, part of the fix for #522 #523
Closed
cebtenzzre added a commit that referenced this issue Jun 20, 2023
@cebtenzzre
utilities: fix rm_util_size_string_to_bytes
6229f4a 
- Use ULLONG_MAX instead of ULONG_MAX so overflow detection works on
  platforms where sizeof(long) != sizeof(long long).
- Do not rely on specific behavior of cast-to-integer overflow. On
  platforms such as i686 and aarch64, this produces a different result.

Fixes #522
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix max sizes on x86, part of the fix for #522 sbraz/rmlint
2 participants
@sbraz @cebtenzzre