Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speeding up bulk executions shows wrong loading indicator #3837

Open
schmanu opened this issue Jun 12, 2024 · 0 comments
Open

Speeding up bulk executions shows wrong loading indicator #3837

schmanu opened this issue Jun 12, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@schmanu
Copy link
Member

schmanu commented Jun 12, 2024

Bug description

For bulk executions we do not do gas estimation in our interface.
Therefore we do not store the used gasLimit in the pendingTxSlice.

The SpeedUpModal shows a loading state if the gasLimit is undefined.

We need to either

  • Do gas estimation for bulk executions
  • Do not show a loading state and transaction price for speeding up bulk executions.

Environment

  • Browser: Chrome
  • Wallet: MetaMask
  • Chain: Ethereum mainnet

Steps to reproduce

  1. Queue and sign 2 or more transactions
  2. Execute them with a low gas price
  3. Speed them up

Expected result

The speedup modal shows the new gas price and when submitting speeds up the bulk execution

Obtained result

The speedup modal remains in a loading state.
Submitting the transaction works though and the tx gets sped up.

Screenshots

Screenshot 2024-06-12 at 13 53 14

@schmanu schmanu added the bug Something isn't working label Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: New issues
Development

No branches or pull requests

1 participant