Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modules can be enabled before SafeSetup #1789

Open
Uxio0 opened this issue Dec 4, 2023 · 0 comments
Open

Modules can be enabled before SafeSetup #1789

Uxio0 opened this issue Dec 4, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@Uxio0
Copy link
Member

Uxio0 commented Dec 4, 2023

Describe the bug
If there's an initializator when creating a Safe, modules can be enabled before SafeSetup is called, but this might not be indexed as Safe was not created at that point.

Currently everything should be working, as Safe gets reindexed after creation and transaction ends up appearing, but we must find a better solution. Link to the problematic line of code

To Reproduce
Take a look at: https://goerli.etherscan.io/tx/0x691b5cf29776520b97eca0d0d2966aeba507f2e9ee70a17c37b54fb2b15b968d#eventlog

Solution
Solution is not really straightforward and might require to refactor the tx processor.

@Uxio0 Uxio0 added the bug Something isn't working label Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant